Fix break room access and crates underneath crates logic #5347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malkierian
approved these changes
Apr 8, 2025
Archez
approved these changes
Apr 9, 2025
Varuuna
pushed a commit
to Varuuna/Shipwright
that referenced
this pull request
Apr 12, 2025
…ers#5347) * fix break room acces and crates underneath crates logic * apply GF_JUMP to the jump from NEAR_GS to LONG_ROOF to reach BREAK_ROOM
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
…ers#5347) * fix break room acces and crates underneath crates logic * apply GF_JUMP to the jump from NEAR_GS to LONG_ROOF to reach BREAK_ROOM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the logic that caused logic to think you could reach break room when you could not, or above jail without a hookshot. Break room requires you to either be able to longshot to the jail windowsill to jump down, to reach the chest to jump down, or to hover boots/trick-worthy jump from near the skulltula to the long roof and then to break room. From there to reach above jail requires a hookshot. This ball of logic should properly account for that.
This PR also makes a small fix to the crate under a crate as child in the HBA range, as while you can easily break that crate, the drop lands ontop of the crate above it, meaning you need either a way to break the top crate first, or a boomerang to get the drop.
This fix is included in #5338 , but needed to be rewritten due to the blob of a GF region.
Build Artifacts