Rando: Fix checking gSaveContext for used small keys #5346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malkierian
approved these changes
Apr 7, 2025
Varuuna
pushed a commit
to Varuuna/Shipwright
that referenced
this pull request
Apr 12, 2025
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here was that
GetUsedSmallKeyswas checkinggSaveContextfor switch flags, even during seed generation. It was causing issues with seeds generated when save files already existed or were loaded. Apparently this was added for the in-game accessibility tracking, so the impact during seed gen apparently wasn't checked.Fixed by making
GetUsedSmallKeysa member of theLogicclass so it can accessmSaveContext(which points togSaveContextduring gameplay).This should fix several issues reported during the Glitchless weekly seeds that started after 9.0.0 came out (this bug had no affect on No Logic seeds).
Build Artifacts