Skip to content

fix blank names in spoiler #5329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leggettc18 merged 2 commits into from
Apr 7, 2025
Merged

fix blank names in spoiler #5329

leggettc18 merged 2 commits into from
Apr 7, 2025

Conversation

@briaguya0
Copy link
Contributor

@briaguya0 briaguya0 commented Apr 5, 2025 •
edited by github-actions bot
Loading

fixes the item names getting into spoiler as blank part of #5309

Screenshot From 2025-04-05 12-54-11

Screenshot From 2025-04-05 12-59-03

Note

i know the screenshot is of the alley house key not the guard house key, it was just the quickest one to get to when testing

Build Artifacts

@Archez
Copy link
Contributor

Archez commented Apr 6, 2025

Looks like there is another pair of .english/.french in the spolier writing for ice trap trick names. Might want this fix there as well as there are a couple trick names without french text.

@briaguya0
Copy link
Contributor Author

briaguya0 commented Apr 7, 2025

Looks like there is another pair of .english/.french in the spolier writing for ice trap trick names. Might want this fix there as well as there are a couple trick names without french text.

@Archez I think these are the ones you were referring to c8e3bea

@leggettc18 leggettc18 merged commit 98146c2 into HarbourMasters:develop-blair Apr 7, 2025
6 checks passed
Varuuna pushed a commit to Varuuna/Shipwright that referenced this pull request Apr 12, 2025
@briaguya0 @Varuuna
fix blank names in spoiler (HarbourMasters#5329)
21295ff 
* fix blank names in spoiler

* replace a couple more `.english`/`.french` with `.GetEnglish()`/`.GetFrench()`
krazyjakee pushed a commit to krazyjakee/OOT that referenced this pull request Sep 6, 2025
@briaguya0 @krazyjakee
fix blank names in spoiler (HarbourMasters#5329)
229c9f7 
* fix blank names in spoiler

* replace a couple more `.english`/`.french` with `.GetEnglish()`/`.GetFrench()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Archez Archez Archez approved these changes

@leggettc18 leggettc18 leggettc18 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@briaguya0 @Archez @leggettc18