Fix copyright tex for GC JP #5324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Updated to also include changes for uniquely naming the copyright textures in the JP CE version as 2004. |
Contributor
|
is there any more nuance to add to the width calculation or is #define COPYRIGHT_TEX_WIDTH (isGC ? 160 : 128)
#define COPYRIGHT_TEX_LEFT (isGC ? 78 : 94)still accurate? |
Contributor
Author
|
Yes, all GC copyright tex have the same width/position. The only one that has something different per decomp is iQue which we don't support. |
briaguya0
approved these changes
Apr 6, 2025
briaguya0
approved these changes
Apr 6, 2025
Malkierian
approved these changes
Apr 8, 2025
Varuuna
pushed a commit
to Varuuna/Shipwright
that referenced
this pull request
Apr 12, 2025
* Fix copyright tex for GC JP * add 2004 texture for jp ce
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
* Fix copyright tex for GC JP * add 2004 texture for jp ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GC JP versions (not CE), only have a texture for the copyright matching the year 2002.
This adjusts the name of the texture extracted and updates the title screen logo to display 2002 as appropriately and matching decomp (when only the GC JP version is loaded, or language is set to JPN with any GC version).
Will require regen for these specific versions, which we already are expecting for 9.0.1 from the boss title card fix.
Build Artifacts