Skip to content

Conversation

@leggettc18
Copy link
Contributor

@leggettc18 leggettc18 commented Apr 3, 2025

Before, starting with Master Sword would logically assume you had Master Sword, but not actually put it in your Inventory. This fixes that, automatically equipping it if Starting as Adult Link (but not as Child Link). I don't think auto-equipping would break any glitches, but even if it did we do have options to allow unequipping it now.

Fixes #5300

Build Artifacts

Copy link
Contributor

@Archez Archez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a bit strange to me that you can have "shuffle MS sword" on but then also enable "start with MS sword", seems like turning off shuffle MS is the equivalent of starting with MS anyways. Feels like to me we could just drop "start with MS sword" as an option, unless I'm missing something else that it does.

Approving this though to at least squash the bug.

@leggettc18
Copy link
Contributor Author

Actually that's a good question. If you don't shuffle Master Sword and start as Adult, do you start with the Master Sword in your inventory? Or do you have to go to the Temple of Time first? Because the latter creates a compelling reason to do this in Entrance Rando specifically.

Regardless of that though, the main implication of combining these settings is that Shuffle and Start With both being on means that you start with Master Sword, but the Master Sword Pedestal is still a check.

@Archez
Copy link
Contributor

Archez commented Apr 3, 2025

Actually that's a good question. If you don't shuffle Master Sword and start as Adult, do you start with the Master Sword in your inventory? Or do you have to go to the Temple of Time first? Because the latter creates a compelling reason to do this in Entrance Rando specifically.

If starting as child, there is no MS in inventory until you change age (then you automatically have MS sword).
If starting as adult, you instantly have MS equipped.

Regardless of that though, the main implication of combining these settings is that Shuffle and Start With both being on means that you start with Master Sword, but the Master Sword Pedestal is still a check.

Ah yeah, I guess that is a thing. Just felt weird to my brain at first.

@Pepper0ni
Copy link
Contributor

Pepper0ni commented Apr 3, 2025

You recieve it on spawn as adult, matching vanilla behiaviour. IIRC the reason it was added was some edge case involving SoT to change age, though I've always considered the reasoning fragile.

@leggettc18
Copy link
Contributor Author

Ah OK, so just the second of the two reasons then. Though I actually kind of like the sound of starting as Adult with no sword and needing to find Temple of Time.

@Archez Archez merged commit e2bb2ed into HarbourMasters:develop-blair Apr 4, 2025
6 checks passed
krazyjakee pushed a commit to krazyjakee/OOT that referenced this pull request Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Master Sword Shuffled ✅ Master Sword Start With ✅ No Master Sword Start With / In The Pool

3 participants