-
Notifications
You must be signed in to change notification settings - Fork 632
Fix the start with Master Sword option #5304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the start with Master Sword option #5304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a bit strange to me that you can have "shuffle MS sword" on but then also enable "start with MS sword", seems like turning off shuffle MS is the equivalent of starting with MS anyways. Feels like to me we could just drop "start with MS sword" as an option, unless I'm missing something else that it does.
Approving this though to at least squash the bug.
|
Actually that's a good question. If you don't shuffle Master Sword and start as Adult, do you start with the Master Sword in your inventory? Or do you have to go to the Temple of Time first? Because the latter creates a compelling reason to do this in Entrance Rando specifically. Regardless of that though, the main implication of combining these settings is that Shuffle and Start With both being on means that you start with Master Sword, but the Master Sword Pedestal is still a check. |
If starting as child, there is no MS in inventory until you change age (then you automatically have MS sword).
Ah yeah, I guess that is a thing. Just felt weird to my brain at first. |
|
You recieve it on spawn as adult, matching vanilla behiaviour. IIRC the reason it was added was some edge case involving SoT to change age, though I've always considered the reasoning fragile. |
|
Ah OK, so just the second of the two reasons then. Though I actually kind of like the sound of starting as Adult with no sword and needing to find Temple of Time. |
Before, starting with Master Sword would logically assume you had Master Sword, but not actually put it in your Inventory. This fixes that, automatically equipping it if Starting as Adult Link (but not as Child Link). I don't think auto-equipping would break any glitches, but even if it did we do have options to allow unequipping it now.
Fixes #5300
Build Artifacts