Skip to content

Conversation

@serprex
Copy link
Contributor

@serprex serprex commented Apr 2, 2025

checked that -print0 & -0 also exist in apple's manpages
(GNU find extends find -exec to be able to batch arguments like xargs, but won't work on mac)

Build Artifacts

@serprex serprex force-pushed the simplify-clang-format branch from a30edca to d0d45eb Compare April 2, 2025 00:22
Copy link
Contributor

@Archez Archez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these changes, working on mac 👍

@briaguya0
Copy link
Contributor

would you mind rebasing this on latest dev so we can see clang-format pass CI? the changes look good but it just feels a bit better to have a clang-format pr pass clang-format

checked that -print0 & -0 also exist in apple's manpages
@serprex serprex force-pushed the simplify-clang-format branch from d0d45eb to 46c8f9a Compare April 2, 2025 14:08
@serprex
Copy link
Contributor Author

serprex commented Apr 2, 2025

@briaguya-ai done

@Malkierian
Copy link
Contributor

Should this target develop-blair now?

@serprex
Copy link
Contributor Author

serprex commented Apr 3, 2025

Should this target develop-blair now?

it's not a correctness issue, just cleaning up unnecessary sed

@Archez Archez merged commit ef8fa17 into HarbourMasters:develop Apr 3, 2025
6 checks passed
xxAtrain223 pushed a commit to xxAtrain223/Shipwright that referenced this pull request May 4, 2025
checked that -print0 & -0 also exist in apple's manpages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants