Skip to content

Implement Log Level selector setting #5263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Malkierian merged 7 commits into from
May 23, 2025
Merged

Implement Log Level selector setting #5263

Malkierian merged 7 commits into from
May 23, 2025

Conversation

@Malkierian
Copy link
Contributor

@Malkierian Malkierian commented Mar 31, 2025 •
edited by github-actions bot
Loading

Archez
Archez reviewed Mar 31, 2025
View reviewed changes
@Malkierian
Copy link
Contributor Author

Malkierian commented Apr 2, 2025

Updated and feedback addressed.

Archez
Archez reviewed Apr 3, 2025
View reviewed changes
briaguya0
briaguya0 approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@briaguya0 briaguya0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at first the fact that it doesn't change log file output felt a bit odd but i figure we'd end up wanting extra logic to make sure people don't have empty logs when trying to diagnose bug reports (which feels out of scope for this PR)

:shipit:

@Malkierian
Copy link
Contributor Author

Malkierian commented May 13, 2025

What do you mean by changing log file output?

@Malkierian
Copy link
Contributor Author

Malkierian commented May 13, 2025

Oh, wait, you mean the log file output remains the same regardless? No, that probably should be handled. I thought this would change all logging. The main point was to be able to remove traces when debugging.

@briaguya0
Copy link
Contributor

briaguya0 commented May 13, 2025

Oh, wait, you mean the log file output remains the same regardless? No, that probably should be handled. I thought this would change all logging. The main point was to be able to remove traces when debugging.

i was going off

Shipwright/soh/soh/SohGui/SohMenuDevTools.cpp

Lines 93 to 94 in cffe16f

.Tooltip("The log level determines which messages are printed to the console."
" This does not affect the log file output")

so i assumed it was intentional

@Malkierian
Copy link
Contributor Author

Malkierian commented May 13, 2025

Hmm. Well, it was copied over from 2ship, I believe, so that may be how they did it over there, too. But yeah, the main thing was the console, because the traces could make debug really chug sometimes.

@Malkierian Malkierian merged commit ae480e1 into HarbourMasters:develop May 23, 2025
6 checks passed
@Malkierian Malkierian deleted the log-level-selector branch May 23, 2025 21:03
krazyjakee pushed a commit to krazyjakee/OOT that referenced this pull request Sep 6, 2025
@Malkierian @krazyjakee
Implement Log Level selector setting (HarbourMasters#5263)
657a90b 
* Implement Log Level selector setting.

* run clang

* Enum for default value.

* PR feedback: use CVAR_DEVELOPER_TOOLS in CVar builder.

* Slight change to try to force a PR update.

* screw you clang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Archez Archez Archez left review comments

@briaguya0 briaguya0 briaguya0 approved these changes

+1 more reviewer

@Pepper0ni Pepper0ni Pepper0ni left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Malkierian @briaguya0 @Archez @Pepper0ni