-
Notifications
You must be signed in to change notification settings - Fork 632
skip bottling big poes #5247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip bottling big poes #5247
Conversation
Pepper0ni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on some discord chat before going deeper, but if we are skipping the poe merchant in this process, we want to move the big poe check to RR_HYRULE_FIELD while this setting is on as actually reached them is no longer a requirement to get the check unless i misunderstand something.
8ed8a1f to
6b0f772
Compare
|
Taking some design inititive here to start a discussion, I think we should not make this a setting and instead make it the default on all seeds to remove the ever-increasing headache that is big poe softlock logic. For those unaware, when shuffling interior or overworld entrances, there's a check in entrance validation to make sure that the player can empty big poe bottles with no items. This is to account for someone possibly going out of logic to kill big poes and fill thier bottles, but then need the bottles to get something that gives them big poe access. This cannot be handled with normal logic because it is accounting for illogical actions. This check has gotten more complex with overworld locks however, will get get even more complex with NPC souls, because they also stop handing in big poe bottles even in vanilla. Issues with this are the cause of the Inteior shuffle fails in 9.0 and have result in some very wierd logic where guard house key is sometimes needed to use bottles. Rarther than add a setting that would force us to maintain that, I believe that it would be better to force this the default because if implemented as so, it should have minimal effect on practical gameplay:
With this implementation, the only gameplay difference between the new system and the old is that they player does not need to run laps between hyrule field and the poe merchant, which most would consider QoL, and I consider that preferable to the esoteric bottle logic that is caused by the threat of big poe softlocks. |
c11627d to
809b952
Compare
422574c to
ff2a906
Compare
ff2a906 to
df34378
Compare
Pepper0ni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to remove an instance on AreCheckingBigPoes in ProcessExits.
Also don't forget to adjust the presets now big poes start at 0.
9625187 to
0072284
Compare
Pepper0ni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actor is still breaking when being handed a big poe bottled, but I checked develop and that's an existing bug so I won't block over it (probably needs a new hook to skip a function)
Otherwise glad to have the poes headache gone even if there could be more polish on the text.
Malkierian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming how Pepper0ni outlined how it should work, which I now agree with after some time to think about it, is how it was implemented here (which is how the code looks), this should be good to go. May catch some people off guard at first, but overall I think this will just work and feel better all around.
|
Pretty simple conflicts to resolve, looks like, and I'll look at pushing this through. |
empty bottle still required to collect avoids logic needing to work around player soft locking by filling bottles without poe collector access
0072284 to
4c6aef1
Compare
* setting to skip bottling big poes empty bottle still required to collect avoids logic needing to work around player soft locking by filling bottles without poe collector access * No option, zero option * TEXT_BIG_POE_COLLECTED_RANDO * update preset * fix talking to poe collector after receiving item
empty bottle still required to collect
avoids logic needing to work around player soft locking by filling bottles without poe collector access
Build Artifacts