location_access: don't short circuit event access logic #5216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pepper0ni
approved these changes
Mar 27, 2025
event logic is only run while event isn't set
serprex
force-pushed
the
no-event-access-short-circuit
branch
from
ed79e9b to
d4ff436
Compare
Contributor
|
So the event logic was already not running if it was set true, and this is just cleaning up the self-referencing? |
Contributor
Author
Yes |
Contributor
| this line here is the check in question |
Malkierian
approved these changes
May 13, 2025
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
…rs#5216) event logic is only run while event isn't set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
event logic is only run while event isn't set
Build Artifacts