Move Shadow Tag Mode hook to its own file #5179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malkierian
approved these changes
May 13, 2025
Contributor
|
Oh, right, before I merge this, I'd like you to follow suit with the pattern I've decided to implement with RegisterInitFunc function names being more specific to the feature being registered. They're static, so for now they don't bleed through global scoping, but they're not namespaced, so it would just be a good idea for multiple reasons. Same goes for #5174 and #5178. |
Contributor
Author
|
I think I did it right, but I'm re-requesting your review to be sure. |
Contributor
|
I've seen some others just do something like |
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
* Move Shadow Tag Mode hook to its own file * Rename initFunc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only one of the hooks is conditioned on the CVar. I'm wondering if they all should be.
Build Artifacts