Ship of Harkinian 64 bit compilation #431
Conversation
This check will fail on Windows before it gets merged btw
Some modifications to handle backslashes and forward slashes, along with some optimizations to speed up OTR generation.
Emill
changed the title
|
@NEstelami @KiritoDv @Emill @Kenix3 If there are no other major blockers, how do you all feel about merging in this branch and fixing any other minor issues that appear separately? This PR has a lot of useful and helpful additions contained only within this branch that would enable a couple of other efforts + it would allow more people to be able to test and contribute to the stabilization of Or if not, is there anything we can do to help with the effort? is there a list of bugs somewhere that we (other devs) can help track down and fix? :) |
Just a couple days ago it finally got some code submissions that were blocking it to be merged. Give it a few days for review and it will get in. |
Kenix3
left a comment
Kenix3
left a comment
There was a problem hiding this comment.
First, has the 32 bit build been tested on this branch at all?
Second, why is SoH building StormLib in the makefile, but not libultraship? StormLib is only included to SoH via libultraship, so the logical place to build it would be libultraship.
No rush. Was just asking to avoid having a big PR that gets harder to rebase with an ever changing I'm also just genuinely trying to help. I know moving such big efforts forward can be a big and tiring task and right now it seems that that responsibility is solely falling on one or two people. |
| return (info->write_index - info->read_index) / 4; | ||
| } | ||
|
|
||
| int PulseAudioPlayer::GetDesiredBuffered() |
There was a problem hiding this comment.
can't this be a constexpr like the other one?
* Extract StormLib building from soh to ZAPDTR ZAPDTR is currently where we have everything… though this might not make the most sense. * Do not import storm as a relative
Ship of Harkinian 64 bit compilation
No description provided.