Fix disable lod breaking certain effects #4245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The disable lod enhancement was overwriting the lod value in
SkelCurve_DrawLimbwhich uses lod to mean something else. In here, a lod value of0means render one DL as OPA, and a lod value of1means render a DL as OPA and another DL as XLU.There are only 3 instances of
SkelCurve_DrawLimb, all of which explicitly use a lod value of1to render transparent effects.I've removed this override as it is not correct for this method.
I also removed a separate override for lod value in z_player that was redundant, as eventually the player code just calls
SkelAnime_DrawFlexLodwhich already has the disable lod override within it.Build Artifacts