-
Notifications
You must be signed in to change notification settings - Fork 632
Add GUI toggle for Ganon blood color, also fix minor unrelated typos in ImGui #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
On the Discord, there's no clear consensus on whether this should be under Cosmetics (preferred by pancake and myself), Enhancements > Graphics or a brand new Enhancements > Censorship section (suggested by Purple Hato). Open to suggestions. If you go with creating a brand new section, personally I'd suggest something more indicative of what the actual change does like Restoration rather than Censorship, since it's more like uncensorship ... but don't name it Uncensorship. |
I'd say go for Enhancements > 1.0 Restoration because I am sure with time we will have more of these |
|
I think being specific about it being a 1.0 Restoration would become misleading as the changes occurred over many versions.
I left out a lot of other changes, as there were many bug fixes across versions in addition to these changes. For the blood specifically, it's more of an NTSC 1.1 restoration, but if we eventually have the crescent moon symbols back, that would be an NTSC 1.2/PAL 1.1 restoration. In theory somebody might want to restore the original NTSC 1.0 Swordless Link glitch, etc. The ultimate "restoration" would take the best things from each version rather than any specific revision, so I think it makes sense to be a bit more ambiguous. |
|
when you say also you are sure about Pal 1.0 ? |
Just Restoration unless somebody has a better idea for it.
Yeah, the PAL 1.0 version is almost identical to NTSC 1.2. The build dates in the ROMs confirm this: Compiled two days apart (November 10/12), so they have mostly the same bugs/changes. |
|
As I've stated elsewhere, for the location of this setting: Let's not argue on it too much. We're planning a clean up, grouping, and simple/advanced UIs soon. |
…in ImGui (HarbourMasters#411) * Add GUI toggle for Ganon blood color * Move to new Restoration section * rm accidental line break * Simplify booleans
…in ImGui (HarbourMasters#411) * Add GUI toggle for Ganon blood color * Move to new Restoration section * rm accidental line break * Simplify booleans
…in ImGui (HarbourMasters#411) * Add GUI toggle for Ganon blood color * Move to new Restoration section * rm accidental line break * Simplify booleans
What it says on the tin. Current SoH behavior is inconsistent, with Ganondorf's blood restored to the original red, while (Pig) Ganon is unchanged, with updated green blood. This PR makes green the default but adds a checkbox under Cosmetics to restore the original red blood.
Also made a minor tweak to GUI texts to use the correct CamelCase capitalization of "GameCube".