Skip to content

Conversation

@vaguerant
Copy link
Contributor

What it says on the tin. Current SoH behavior is inconsistent, with Ganondorf's blood restored to the original red, while (Pig) Ganon is unchanged, with updated green blood. This PR makes green the default but adds a checkbox under Cosmetics to restore the original red blood.

Also made a minor tweak to GUI texts to use the correct CamelCase capitalization of "GameCube".

@vaguerant
Copy link
Contributor Author

On the Discord, there's no clear consensus on whether this should be under Cosmetics (preferred by pancake and myself), Enhancements > Graphics or a brand new Enhancements > Censorship section (suggested by Purple Hato). Open to suggestions. If you go with creating a brand new section, personally I'd suggest something more indicative of what the actual change does like Restoration rather than Censorship, since it's more like uncensorship ... but don't name it Uncensorship.

@Baoulettes
Copy link
Contributor

On the Discord, there's no clear consensus on whether this should be under Cosmetics (preferred by pancake and myself), Enhancements > Graphics or a brand new Enhancements > Censorship section (suggested by Purple Hato). Open to suggestions. If you go with creating a brand new section, personally I'd suggest something more indicative of what the actual change does like Restoration rather than Censorship, since it's more like uncensorship ... but don't name it Uncensorship.

I'd say go for Enhancements > 1.0 Restoration because I am sure with time we will have more of these
in both case since there is only one mod/fix for it I guess that fine where ever it is, as preference I would put a new category that indicate that not a mod or something like that but a thing Nintendo themselve did and you restored it :)

@vaguerant
Copy link
Contributor Author

I think being specific about it being a 1.0 Restoration would become misleading as the changes occurred over many versions.

Version Red Blood Fire Temple Chanting Crescent Moons
NTSC 1.0 ✔️ ✔️ ✔️
NTSC 1.1 ✔️ ✔️ ✔️
PAL 1.0 ✔️
NTSC 1.2 ✔️
PAL 1.1 ✔️
GCN

I left out a lot of other changes, as there were many bug fixes across versions in addition to these changes. For the blood specifically, it's more of an NTSC 1.1 restoration, but if we eventually have the crescent moon symbols back, that would be an NTSC 1.2/PAL 1.1 restoration. In theory somebody might want to restore the original NTSC 1.0 Swordless Link glitch, etc. The ultimate "restoration" would take the best things from each version rather than any specific revision, so I think it makes sense to be a bit more ambiguous.

@Baoulettes
Copy link
Contributor

when you say it makes sens to be a bit more ambiguous you mean calling it just restoration or placing it in graphic ?

also you are sure about Pal 1.0 ?
I remember as kid playing with chants red blood in France and well that Pal.
I need to find an nintendo 64 to confirm that I still have the game
(I could and probably am wrong there)

@vaguerant
Copy link
Contributor Author

when you say it makes sens to be a bit more ambiguous you mean calling it just restoration or placing it in graphic ?

Just Restoration unless somebody has a better idea for it.

also you are sure about Pal 1.0 ? I remember as kid playing with chants red blood in France and well that Pal. I need to find an nintendo 64 to confirm that I still have the game (I could and probably am wrong there)

Yeah, the PAL 1.0 version is almost identical to NTSC 1.2. The build dates in the ROMs confirm this:

 PAL 1.0: 98-11-10 14:34:22
NTSC 1.2: 98-11-12 18:17:03

Compiled two days apart (November 10/12), so they have mostly the same bugs/changes.

@vaguerant vaguerant changed the title Add GUI toggle for Ganon blood color Add GUI toggle for Ganon blood color, also fix minor unrelated typos in ImGui May 24, 2022
@Kenix3
Copy link
Collaborator

Kenix3 commented Jun 6, 2022

As I've stated elsewhere, for the location of this setting: Let's not argue on it too much. We're planning a clean up, grouping, and simple/advanced UIs soon.

@Kenix3 Kenix3 merged commit 8cbc4d2 into HarbourMasters:develop Jun 6, 2022
stratomaster64 pushed a commit to stratomaster64/Shipwright that referenced this pull request Jun 13, 2022
…in ImGui (HarbourMasters#411)

* Add GUI toggle for Ganon blood color

* Move to new Restoration section

* rm accidental line break

* Simplify booleans
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this pull request Jun 19, 2022
…in ImGui (HarbourMasters#411)

* Add GUI toggle for Ganon blood color

* Move to new Restoration section

* rm accidental line break

* Simplify booleans
stratomaster64 pushed a commit to stratomaster64/Shipwright that referenced this pull request Jun 20, 2022
…in ImGui (HarbourMasters#411)

* Add GUI toggle for Ganon blood color

* Move to new Restoration section

* rm accidental line break

* Simplify booleans
@vaguerant vaguerant deleted the redblood branch June 28, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants