Trackers MQ Cleanup #4009
Merged
Trackers MQ Cleanup #4009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tie personal notes saving to `OnExitGame()` to account for save scum resets. Hide text input box (but not window) for personal notes when a save isn't loaded to prevent saving over a save's notes while in file select.
…le load..." text in file select (ease of positioning).
Add `IsAreaSpoiled` for tie-in to Item Tracker. Add `SetAreaSpoiled` to unify bitmagic.
…st check collection. Add light yellow color for vanilla dungeon abbreviations to match the purple for MQ.
briaguya0
reviewed
Apr 7, 2024
Contributor
briaguya0
left a comment
briaguya0
left a comment
There was a problem hiding this comment.
overall this seems reasonable, couple questions in there (it seems like a lot of the ternaries are backwards but maybe i'm not understanding the logic correctly)
…` were inverted. Fixed that.
briaguya0
reviewed
Apr 8, 2024
Contributor
briaguya0
left a comment
briaguya0
left a comment
There was a problem hiding this comment.
this looks almost ready to ship, couple last comments
briaguya0
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR had one main goal: prevent the trackers from spoiling dungeon MQ status prematurely. To accomplish this, I persisted
areasSpoiledin the check tracker, then used functions referencing that in the item tracker to unify the point of spoiling across the trackers. I then set it up to spoil dungeons only on specific entrances that have obvious, immediate visual cues. Otherwise, they rely on the dungeon map or collecting the first check in a dungeon. The max key counts are hidden until the dungeon is registered as spoiled.This also adds a light yellow color to the dungeon abbreviations if they're known to be vanilla, to differentiate from unspoiled dungeons.
Entrances that spoil: Deku Tree front, Dodongo's Cavern back, Jabu Jabu both, Forest Temple front, Fire Temple both, Water Temple back, Spirit Temple front, Shadow Temple back, Ice Cavern, GTG, IGC front. From boss door (back) was added to account for dungeon chain possibilities in dev-rando.
Known issues: currently,
RSK_RANDOM_MQ_DUNGEONSremainsRO_MQ_DUNGEONS_SET_NUMBEReven if selection was used (which should be spoiled), andRSK_MQ_DUNGEON_COUNTis never set above 0, so being set to 12 doesn't register either, both of which should be situations where they get spoiled right at the start.RO_MQ_DUNGEONS_NONEstill works, though.Build Artifacts