[Fix] Disable Lod Applies To Everything #3989
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archez
approved these changes
Apr 4, 2024
Contributor
Archez
left a comment
Archez
left a comment
There was a problem hiding this comment.
I would also be ok with this targeting macready if you are willing to rebase it.
Member
Author
|
yea lemme open a new pr cause my last few attempts at rebasing same branch it just never pushes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3978
It looks as though gDisableLod only applies to player limbs and not others. This adds a cvar check to inside the respsective functions they are handled, although the player check is still required due to additional checks against the lod within the player draw flow.
Build Artifacts