Skip to content

Conversation

@Baoulettes
Copy link
Contributor

@Baoulettes Baoulettes commented May 20, 2022

With this combo box become easier to make.
You can set a first default value to show to the user with last argument, by default if not set it will be 0 (first entry).
following what the filters list did and made it easier so anyone could use them without having to create many lines.
This will be used later in another PR, but also made Filter list follow scheme of other type of ImGui items :)
(it still need reload.)

PS: Right now in the combo box array you can not have a single character entry that how I check if that a valid entry, also if anyone know how I can get the size of the array in the function that would solve this issue

Copy link
Contributor

@MelonSpeedruns MelonSpeedruns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, however fix the conflict before merging please.

Copy link
Collaborator

@Kenix3 Kenix3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge pending conflict resolution.

@MelonSpeedruns MelonSpeedruns merged commit c92524a into HarbourMasters:develop Jun 3, 2022
@Baoulettes Baoulettes deleted the ComboBox-Simplification branch July 6, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants