Skip to content

Fix crashing when creating a new file #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Archez merged 1 commit into from
Dec 29, 2023
Merged

Fix crashing when creating a new file #3764

Archez merged 1 commit into from
Dec 29, 2023

Conversation

@Pepe20129
Copy link
Contributor

@Pepe20129 Pepe20129 commented Dec 29, 2023

The ToT medallions enhancement crashed due to gPlayState being null when items are given upon creation of a randomizer save.

@Pepe20129 Pepe20129 mentioned this pull request Dec 29, 2023
Closed
@inspectredc
Copy link
Member

inspectredc commented Dec 29, 2023

I believe we shifted to using
if (!GameInteractor::IsSaveLoaded()) return;
Although if there's a reason that this shouldn't be used then this is good!

@Pepe20129
Copy link
Contributor Author

Pepe20129 commented Dec 29, 2023

Some hooks still use if (!gPlayState) return; and using if (!GameInteractor::IsSaveLoaded()) return; will prevent stuff from working in the debug save file (for example the hold L to levitate cheat doesn't work in the debug save file anymore). I decided to use gPlayState to avoid problems with the debug save file.

Archez
Archez approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@Archez Archez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this. Rather not use ::IsSaveLoaded for something like this.

@Archez
Copy link
Contributor

Archez commented Dec 29, 2023

Bypassing merge timeline to resolve develop crashes

@Archez Archez merged commit 807b00a into HarbourMasters:develop Dec 29, 2023
@Pepe20129 Pepe20129 deleted the fix_tot_medallions branch December 29, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Archez Archez Archez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pepe20129 @inspectredc @Archez