Skip to content

[Debug] Add more commands and info to DL Viewer #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
briaguya0 merged 1 commit into from
Dec 26, 2023
Merged

[Debug] Add more commands and info to DL Viewer #3504

briaguya0 merged 1 commit into from
Dec 26, 2023

Conversation

@Archez
Copy link
Contributor

@Archez Archez commented Dec 10, 2023 •
edited
Loading

This is a collection of changes that I had in my stashes regarding the DL viewer.
Mainly it adds all (or mostly all) the opcodes, indicates two-wide opcodes, and prints out information for some opcodes that I found useful.

In addition I:

  • Improved the search for DLs to hopefully include all DLs in the OTRs, not just ones that end in DL
  • Alphabetized the list
  • There is a crude debounce to improve the performance when searching
  • Added a resource type validation so that things like textures don't accidentally crash the viewer
  • Added a try catch in the event that a DL got corrupted.

I didn't bother going too crazy, especially knowing that a better DL viewer is being worked on over at the LUS side.

Build Artifacts

garrettjoecox
garrettjoecox approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@garrettjoecox garrettjoecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty ty ty ty

@briaguya0 briaguya0 merged commit 6a7bcc4 into HarbourMasters:develop Dec 26, 2023
@Archez Archez deleted the update-dl-viewer branch January 2, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettjoecox garrettjoecox garrettjoecox approved these changes

@briaguya0 briaguya0 briaguya0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Archez @garrettjoecox @briaguya0