Only emit changed flags #3489
Merged
Only emit changed flags #3489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettjoecox
force-pushed
the
only-emit-changed-flags
branch
2 times, most recently
from
a835edc to
913b188
Compare
Archez
approved these changes
Dec 5, 2023
Contributor
Archez
left a comment
Archez
left a comment
There was a problem hiding this comment.
Nice optimization 👍
I added a minor name change suggestion, but non-blocking for merge.
garrettjoecox
force-pushed
the
only-emit-changed-flags
branch
from
913b188 to
e7227cc
Compare
briaguya0
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QOL for both anchor and logs, some actors would set or unset flags every frame regardless of their state which caused lots of unnecessary logs and hook emits.
Build Artifacts