Fix new GBK check for vanilla #3473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettjoecox
approved these changes
Nov 30, 2023
briaguya0
approved these changes
Dec 2, 2023
Archez
approved these changes
Dec 2, 2023
garrettjoecox
force-pushed
the
gbk-fix-woops
branch
from
16ae876 to
245342d
Compare
garrettjoecox
force-pushed
the
gbk-fix-woops
branch
from
245342d to
a702b3f
Compare
jamieklassen
pushed a commit
to jamieklassen/Shipwright
that referenced
this pull request
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though it's checking the randomizer inf flag, somehow that still passed when in vanilla. So adding the IS_RANDO check makes it so it doesn't give the boss key in vanilla no matter what.
Build Artifacts