Skip to content

Conversation

@leggettc18
Copy link
Contributor

@leggettc18 leggettc18 commented Nov 21, 2023

Implementing some suggestions from my IDE, and addressing some comments received on a PR earlier that didn't actually get resolved in that PR (which were mostly just typos and style comments)

Build Artifacts

Most of these come from CLion Nova. Some of these may be controversial, such as the if-init-statement related ones. Most of them should not be controversial though, like replacing C-style casts with static casts.
Left a few about "Template Arguments can be deduced", and a "Redundant static_cast" for the sake of clarity.
Previously this TODO statement was a question of whether or not we ever want to not output a spoiler log. Eventually we may want different amounts or types of data to be output when generating a seed according to certain settings. For instance, maybe we want a human-readable spoiler log, that has item locations and hint content without the formatting info. Maybe we want a "Plandomizer File", which is that but the hint strings include formatting info so that the formatting/colors can be changed, and eventually we may want to let cosmetic info be specified in there as well. Or maybe we just want a Race/Patch file that just has the seed and settings, for Race files we could also specify non-rando settings that should be locked to certain values. Or maybe want one of each. All of that is stuff that should at least start being handled at the location of this TODO statement.
@leggettc18
Copy link
Contributor Author

Mac OS gave me a lot of trouble with this PR for some reason, may want to get this playtested on Mac before merging.

@leggettc18 leggettc18 merged commit 1cc3201 into HarbourMasters:develop-rando Dec 6, 2023
@leggettc18 leggettc18 deleted the develop-rando-tidy-up branch December 6, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant