Fix two missing changes after ms GI enum was changed & hint fix #3319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettjoecox
changed the title
garrettjoecox
commented
Oct 22, 2023
Archez
approved these changes
Oct 22, 2023
aMannus
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Near the end of the review phase of master sword shuffle, the GI enums used were changed from
0x73to0xE0. One remaining instance of this was left, as well as needing to adjust the size of the trickNameTable (needs to be highest + 1)Additionally sneaking a fix in here for hint generation. AutoFormatHintTextString had an infinite loop in a special case that we happened to not run into yet, we also removed the hardcoded line break from the problematic hint, mostly because it's just not necessary anymore. Re-adding it should be fine if anyone is opposed.
Build Artifacts