Use correct save context for triforce piece collected save data #3301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archez
approved these changes
Oct 18, 2023
Contributor
|
Good thing you found this, lol. The result of this mostly wouldn't be noticeable with something like triforce pieces, but essentially what you were doing was bypassing the freeze state held by SaveManager (saveContext), created at the time of the save request, for what things currently were at the time the save request was processed (gSaveContext). 99.9% of the time those would be the same anyway. |
garrettjoecox
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this and thought it was a bug although im not sure what the result of it is/if it has any problems
Build Artifacts