-
Notifications
You must be signed in to change notification settings - Fork 632
Player Equip Docs #3282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Player Equip Docs #3282
Conversation
|
#3200 relevant but not quite the same, if yours gets merged first I'll just remove the equip changes from my script |
|
Conflicts here, otherwise ready to merge |
|
Updated now, hopefully managed to cover all the additions from MS shuffle. One thing i did change from MS shuffle was a section in z_parameter where instead of reading it now reads effectively doing the vanilla behaviour and then editing the value afterwards only for the master sword shuffle. i did this because it was just neater to write out this way with the docs |
I agree and like this change, especially the part about retaining the vanilla behavior and only applying the rando specific part after it. Helps with readability and keeps the vanilla code as untouched as possible 👍 |
Increases documentation for equipment. Moves to using macros where applicable in SOH code and transfers the rest from decomp. Changes names to match closer to decomp, e.g. BGS -> BIGGORON. Stops the use of Inventory_ChangeEquipment with PLAYER equipment enums instead using the EQUIP_VALUE enums. Notably a fair amount of the GameInteractor force boots process was changed to use this method so will need checking that it still functions properly.
Build Artifacts