Audio Editor clean-up #3256
Merged
Audio Editor clean-up #3256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettjoecox
approved these changes
Oct 4, 2023
Archez
reviewed
Oct 4, 2023
Pepe20129
reviewed
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be more coming after this, but I felt it was good to get a PR out for this before it becomes too out-of-date and it never sees the light of day.
Cleans up the list in
AudioCollection.cppby re-aligning the entries and sorting them by category in code. Also adds a way to exclude sounds both from being randomized, and randomized to.For example, this adds the
Hover BootsandAdult Link - Drinkingsound effects, which only works when it's randomized to something else, but it is silent when used as a replacement for something else. This has to do with the SFX_FLAG those sounds are using.I added the other way around as well in case it's useful, so you can set sounds to be used as a replacement, but can't be randomized itself (could be used for unused sound effects for example).
Again this is just a clean-up pass, there might be more sounds we've been excluding until now that might work only one way around that could be good to add in the future.
Build Artifacts