Add "Navi Targeting Colors" options to Controller LED Color #3254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheepytina
commented
Oct 4, 2023
inspectredc
reviewed
Oct 4, 2023
Member
inspectredc
left a comment
inspectredc
left a comment
There was a problem hiding this comment.
Everything looks good! Left some comments for allowing for cosmetics (which i see now you're planning on adding now lol)
In-progress implementation of Cosmetics Navi colours.
…roller LED. Defaults are now labeled for clarity.
Add Color conversion functions.
sheepytina
changed the title
Uses CVarGetColor24 instead of CVarGetColor to drop alpha from cosmetics editor values, like how Tunic Colors does it. This of course does require me to go with the prior idea of storing the Navi colours without alpha channels.
as they're no longer needed.
inspectredc
suggested changes
Oct 8, 2023
Member
|
I approve and then immediately notice something 🤦🏼 |
Contributor
Author
|
A switch statement mishap has occurred. (5 dead, 12 injured) I think I've fixed it now @inspectredc. Thank you for your patience. |
garrettjoecox
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the DualShock 4/DualSense controller Light Bar mirror whatever colour Navi is.
Build Artifacts