Skip to content

update mac launch script to set SHIP_HOME #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leggettc18 merged 1 commit into from
May 5, 2023
Merged

update mac launch script to set SHIP_HOME #2831

leggettc18 merged 1 commit into from
May 5, 2023

Conversation

@Archez
Copy link
Contributor

@Archez Archez commented May 4, 2023 •
edited by github-actions bot
Loading

Update the mac launch script to rename DATA_SHARE to SHIP_HOME so the the env var can be read by LUS when trying to get the app dir path.
Requires LUS PR: Kenix3/libultraship#192

Build Artifacts

briaguya0
briaguya0 approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@briaguya0 briaguya0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be good for now. i know the people on nixOS are upset that we use SHIP_HOME as the binary, data, and config directory (goes against xdg specs #2285), but i'm happy to have cross-platform consistency here

@Archez Archez changed the title udpate mac launch script to set SHIP_HOME update mac launch script to set SHIP_HOME May 5, 2023
@leggettc18 leggettc18 merged commit 5f0f273 into HarbourMasters:develop-spock May 5, 2023
@Archez Archez deleted the change-mac-script-env branch May 5, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leggettc18 leggettc18 leggettc18 approved these changes

@briaguya0 briaguya0 briaguya0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Archez @leggettc18 @briaguya0