Skip to content

Conversation

@Kenix3
Copy link
Collaborator

@Kenix3 Kenix3 commented May 3, 2023

Copy link
Contributor

@briaguya0 briaguya0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

condensed changelog:
SohImGui -> Ship
ResourceMgr -> ResourceManager
OtrFile -> File
ResourceManager.GetGameVersions() is gone, now use ResourceManager.GetArchive().GetGameVersions()
OTRGlobals::Instance->context->ReadSaveFile -> SaveManager::ReadSaveFile
OTRGlobals::Instance->context->WriteSaveFile -> SaveManager::WriteSaveFile

{ "reset|randomize", Ship::ArgumentType::TEXT },
}});

CVarSave();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not clear why this is being added, anyone have context as to why we have this or load here?

@briaguya0 briaguya0 mentioned this pull request May 3, 2023
@briaguya0 briaguya0 changed the base branch from develop to develop-spock May 3, 2023 06:33
Copy link
Contributor

@briaguya0 briaguya0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to build on switch and wii u this needs the changes from Kenix3/libultraship#191 and this suggestion #2822 (comment)

I was able to test on switch and it's working just fine. I tried using an older version of the devkitppc docker image to build in a way that i could test on cemu and while the build succeeded the testing didn't so getting wii u builds to work can be a separate thing

@leggettc18 leggettc18 merged commit 4980ae8 into develop-spock May 4, 2023
@briaguya0 briaguya0 deleted the lus_updates branch May 4, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants