Move Game Saving to Separate Thread #2820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ude gameplaystats.h` and `InitStatTracker` in the cpp to fix compile issues. Adds SaveContext reference parameters to SaveFunc and existing implementations in preparation for threaded saves.
Platform-specific save code removed. Thread safety added. Will wait for thread pool tasks to finish before resetting or closing.
…deleted at the end of the threaded function to prevent possible issues with the stack.
Archez
reviewed
May 2, 2023
Kenix3
reviewed
May 2, 2023
…OnExitGame` hook seems to be just fine.
Archez
reviewed
May 3, 2023
briaguya0
reviewed
May 3, 2023
…me hooks are the only places it's called now.
Spock -> Develop
…ded-saves Might have build issues...
…vent trying to load a newly "created" save before the save file was actually written.
Spock -> Develop
briaguya0
approved these changes
May 5, 2023
leggettc18
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes game save flow operate on LUS thread pool. Has all thread safety I can think of.
Build Artifacts