fix: remove 100 character limit to rom path #2801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louist103
approved these changes
Apr 30, 2023
leggettc18
requested changes
Apr 30, 2023
Contributor
leggettc18
left a comment
leggettc18
left a comment
There was a problem hiding this comment.
This was a bit of an oversight, great work on the fix! That being said, can you get this rebased onto develop-spock branch rather than develop? I think we'd like to get this into Spock Bravo. @briaguya-ai and any other devs, feel free to weigh in here.
leggettc18
approved these changes
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently only few has tested this new feature. Idk why would they wanna put a size cap to it...
Build Artifacts