Skip to content

Conversation

@briaguya0
Copy link
Contributor

@briaguya0 briaguya0 commented Apr 29, 2023

The logic in gpxprint.c was only looking for replacement debug font textures with an alt/ prefix and only loading them when "Use Alternate Assets" was enabled. This updates the logic to look for replacement textures with and without the alt/ prefix, and display the correct one accordingly.

Before

otr with alt-prefixed font otr with non-alt-prefixed font working? font when "Use Alternate Assets" checked font when "Use Alternate Assets" unchecked
✔️ ✔️ replacement hardcoded
✔️ hardcoded hardcoded
✔️ ✔️ replacement (alt prefixed) hardcoded
✔️ hardcoded hardcoded

After

otr with alt-prefixed font otr with non-alt-prefixed font working? font when "Use Alternate Assets" checked font when "Use Alternate Assets" unchecked
✔️ ✔️ replacement hardcoded
✔️ ✔️ replacement replacement
✔️ ✔️ ✔️ replacement (alt prefixed) replacement (non-alt-prefixed)
✔️ hardcoded hardcoded

we should replace this when we implement #2762

Build Artifacts

Copy link
Contributor

@leggettc18 leggettc18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed debug menu text is replaced when Alt textures are off and a non-alt-prefixed textures OTR is used.

@leggettc18 leggettc18 merged commit c02dcb5 into HarbourMasters:develop-spock May 4, 2023
@briaguya0 briaguya0 deleted the gfxprint-texture-fix branch May 4, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants