use LUS with atmosphere fix #2629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is this version of LUS going to have the sequence duplication issue? |
Contributor
Author
No, it is just LUS as of |
dcvz
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the LUS version used in
develop-khanto be https://github.com/briaguya-ai/libultraship/tree/khanAs of this PR, that branch is just LUS as of khan with Kenix3/libultraship#145 cherry-picked in
If we'd rather have khan use an LUS fork that lives somewhere other than https://github.com/briaguya-ai/libultraship/ I'll gladly change this to use a different fork, but I know there will not be a "LUS stable" available on https://github.com/Kenix3/libultraship
Having divergent LUS versions will be slightly annoying for the next "khan -> dev" merge, but after that's resolved it should be a non-issue
This has been tested
Build Artifacts