Fix: Restore Desert flags wind speed #2600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the resource changes, the flags in Desert Colossus and Haunted Wasteland would briefly appear to move, and then would stop moving entirely.
Looking into, the wind speed value was negative, and the flags have a check for when wind speed is negative they overwrite it to 0.
Comparing to the old resource type this is because the wind speed was original a
uint8_tbut with the new resource changes it was turned into aint8_t, causing the wind value to be negative.This PR switches the wind speed type back to a
unit8_twhich fixes the flags again.I compared the values returned from 5.1.4 to this PR and they are identical for all the wind values now.
Fixes #2447
Build Artifacts