Fix: restrict Ask to Equip enhancement to only vanilla equipment items #2590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Ask to Equip" enhancement was checking for "Yes/No" prompts for items in the range of all equipment (kokiri sword to zora tunic), but was not accounting for the vanilla mod index.
This meant any randomizer items that collided with the same item ID for kokoiri sword <-> zora tunic would equip their respective vanilla item when the randomizer item was purchased from a shop, and the shop owner prompts for "would you like to keep shopping".
This PR adds a simple check against the mod index value to ensure we are only performing the check against vanilla getItems
The following items were impacted:
itemIdisn't the RG_ value)itemIdisn't the RG_ value)itemIdisn't the RG_ value)itemIdisn't the RG_ value)Fixes: #2589
Build Artifacts