Skip to content

Feature - Bonk damage under difficulty options #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcvz merged 2 commits into from
Mar 12, 2023
Merged

Feature - Bonk damage under difficulty options #2584

dcvz merged 2 commits into from
Mar 12, 2023

Conversation

@aMannus
Copy link
Contributor

@aMannus aMannus commented Mar 5, 2023 •
edited
Loading

@jbodner09 jbodner09 mentioned this pull request Mar 6, 2023
Merged
dcvz
dcvz reviewed Mar 6, 2023
View reviewed changes
dcvz
dcvz approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@dcvz dcvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@briaguya0
Copy link
Contributor

briaguya0 commented Mar 6, 2023

copying my message from discord:

since it sounds like we'd need to build out/port over 64rando bonk logic we can probably just get #2584 in as is (bonk damage not in logic) for now. i do assume once it's merged people will start asking about logic for it though (we should probably make a GH issue to add that if nothing else)

jbodner09
jbodner09 reviewed Mar 6, 2023
View reviewed changes
@dcvz dcvz merged commit 76e99ff into HarbourMasters:develop Mar 12, 2023
@aMannus aMannus deleted the bonk-damage branch May 12, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briaguya0 briaguya0 briaguya0 approved these changes

@Archez Archez Archez approved these changes

+2 more reviewers

@jbodner09 jbodner09 jbodner09 left review comments

@dcvz dcvz dcvz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merge ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aMannus @briaguya0 @dcvz @Archez @jbodner09