CMake: Do not force CMAKE_OSX_DEPLOYMENT_TARGET.
#2581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leaves the default of 10.15, but allows a user to change it in the cache. When using Homebrew libraries on newer macOS version, the linker emits warnings: ``` ld: warning: dylib (/opt/homebrew/lib/libSDL2.dylib) was built for newer macOS version (13.0) than being linked (11.0) ```
dcvz
approved these changes
Mar 4, 2023
Contributor
dcvz
left a comment
dcvz
left a comment
There was a problem hiding this comment.
LGTM! No harm in not forcing this, will also help anyone trying to make this run sub 10.15 :)
Contributor
|
Also cool to see another macOS dev :) thanks for the PR @FtZPetruska |
leggettc18
pushed a commit
to leggettc18/Shipwright
that referenced
this pull request
Mar 10, 2023
This leaves the default of 10.15, but allows a user to change it in the cache. When using Homebrew libraries on newer macOS version, the linker emits warnings: ``` ld: warning: dylib (/opt/homebrew/lib/libSDL2.dylib) was built for newer macOS version (13.0) than being linked (11.0) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows user to edit the value of
CMAKE_OSX_DEPLOYMENT_TARGET. It leaves the default of 10.15, but removes theFORCEkeyword, allowing users to change the value through passing-DCMAKE_OSX_DEPLOYMENT_TARGET="<version>"to the command line, using environment variables, or by editing the cache.The reason this change could be useful is that Homebrew libraries are built against your OS's current version SDK, which leads to the following warnings when linking the executable:
(Note that arm64 builds have to target 11.0 or above)
Build Artifacts