Skip to content

Fix: Link spawning in the wrong spot of first game load #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
briaguya0 merged 1 commit into from
Mar 2, 2023
Merged

Fix: Link spawning in the wrong spot of first game load #2573

briaguya0 merged 1 commit into from
Mar 2, 2023

Conversation

@Archez
Copy link
Contributor

@Archez Archez commented Mar 2, 2023 •
edited by github-actions bot
Loading

On the very first game load, Link's spawn would get overridden to 0,0 due to the change age cheat hook having a bad reference to a bool.

This switches the change age hook to use scoped static vars instead of lambda capture by reference.

Also moved the gPlayState checks as an early return in some of the cheat hooks.

Build Artifacts

briaguya0
briaguya0 approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@briaguya0 briaguya0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@briaguya0 briaguya0 merged commit a5bf135 into HarbourMasters:develop-khan Mar 2, 2023
@Archez Archez deleted the fix-link-spawn-change-age branch March 2, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briaguya0 briaguya0 briaguya0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Archez @briaguya0