fix greg hint (and an RSK parsing issue) #2547
Conversation
Archez
left a comment
Archez
left a comment
There was a problem hiding this comment.
Oh gosh.. I messed that up big time. Thanks for catching 😅
aMannus
left a comment
aMannus
left a comment
There was a problem hiding this comment.
Couple of questions about the text ID's that are used here.
| // greg hint, we set it to 0x6E instead | ||
| if (gSaveContext.n64ddFlag && Randomizer_GetSettingValue(RSK_GREG_HINT)) { | ||
| this->actor.textId = 0x6E; | ||
| } else { | ||
| this->actor.textId = 0x84; //Thanks a lot! (Lost) | ||
| } |
There was a problem hiding this comment.
What does the '0x6E' text ID correspond to? Is it an unused text ID?
There was a problem hiding this comment.
0x6E is the text ID for talking to the treasure shop guy after winning the game, it's used on line 100
0x704C is the text ID for talking to the treasure shop guy after buying a key but before going into the game
There was a problem hiding this comment.
I think I would've preferred a check for the treasure chest room ID inside OTRGlobals.cpp so all the checks for it would be in one file, but it's not a big deal overall. Thanks for the explanation.
| } else if (Randomizer_GetSettingValue(RSK_DAMPES_DIARY_HINT) && textId == TEXT_DAMPES_DIARY) { | ||
| messageEntry = CustomMessageManager::Instance->RetrieveMessage(Randomizer::randoMiscHintsTableID, TEXT_DAMPES_DIARY); | ||
| } else if (Randomizer_GetSettingValue(RSK_GREG_HINT) && (textId == 0x704C || textId == 0x6E || textId == 0x84)) { | ||
| } else if (Randomizer_GetSettingValue(RSK_GREG_HINT) && (textId == 0x704C || textId == 0x6E)) { |
There was a problem hiding this comment.
I see there's 2 text ID's here, what's the difference between the 2?
There was a problem hiding this comment.
I see there's 2 text ID's here, what's the difference between the 2?
They're both for the treasure minigame NPC
704C is the "with that key you can xxxx"
6E is the you're a good gambler
5 participants
Build Artifacts