[Accessibility] Add ability to disable camera re-centering on idle #2503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya0
reviewed
Feb 18, 2023
Contributor
briaguya0
left a comment
briaguya0
left a comment
There was a problem hiding this comment.
This is great! Super excited to see the accessibility stuff making it into PRs! Couple little comments (one question, one suggestion)
Comment on lines
1679
to
+1685
| if (anim->startSwingTimer <= 0) { | ||
| if (CVarGetInteger("gA11yDisableIdleCam", 0)) return; | ||
| eyeAdjustment.pitch = atEyeNextGeo.pitch; | ||
| eyeAdjustment.yaw = | ||
| Camera_LERPCeilS(anim->swingYawTarget, atEyeNextGeo.yaw, 1.0f / camera->yawUpdateRateInv, 0xA); | ||
| } else if (anim->swing.unk_18 != 0) { | ||
| if (CVarGetInteger("gA11yDisableIdleCam", 0)) return; |
Contributor
There was a problem hiding this comment.
it's not clear why it's only these 2 places where we want to early return (instead of also in the else), maybe adding a comment explaining would be helpful?
Contributor
Author
There was a problem hiding this comment.
The third method is yaw shifting while normal movements - its what keeps the camera on link.
I'm only changing the shifting from the automatic swing.. when idle the camera swings to behind link.
Contributor
Author
There was a problem hiding this comment.
I added a comment to the else to better explain when its in use
dcvz
force-pushed
the
a11y/disable-idle-cam
branch
from
a09ebf7 to
ddc89e4
Compare
briaguya0
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
Build Artifacts