-
Notifications
You must be signed in to change notification settings - Fork 632
CrowdControl V2: Effect overhaul #2433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dcvz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff here @aMannus ! Overall PR looks good.
It's pointed out places where things could be better but I think it doesn't fall into the responsibility of this PR. I've left a few comments.
soh/soh/Enhancements/game-interactor/GameInteractor_RawAction.cpp
Outdated
Show resolved
Hide resolved
dcvz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 Great work on this @aMannus ! Sorry for the delay :)
Whenever we release the SoH version that includes this, we have to communicate with the CC team to upload the .cs file on their end. They'll also have to add all the effect descriptions and prices which can be found in the .ccpak file, and update the images for the effects accordingly.
Thanks to Caladius for being a sparring partner & helping me with some tedious stuff.
Thanks to RR for lending me their Random Bonk While Rolling code.
Thanks to dcvz for helping me get GameInteractor out the door that made all of this much easier to implement.
To do:
New effects:
Removed Effects:
Other features:
Bugfixes:
Build Artifacts