Rando version warning on different builds #2420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o version warning
…d for rando warning
dcvz
reviewed
Feb 21, 2023
Contributor
dcvz
left a comment
dcvz
left a comment
There was a problem hiding this comment.
A few comments, but overall looks good!
dcvz
approved these changes
Feb 21, 2023
briaguya0
approved these changes
Feb 22, 2023
Contributor
briaguya0
left a comment
briaguya0
left a comment
There was a problem hiding this comment.
couple suggestions, nothing that should block merging!
Contributor
Author
|
This is with translations. There is more text, but I made it still fit in the games original 4:3 ratio so that should be fine. German French |
Co-authored-by: PurpleHato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a warning message in the file select screen for rando saves that were created on a different SoH build.
This works by tracking the build version within the save and exposing it with the file meta info for the file select screen.
For saves that never had a build version stored, this should work as expected (displaying the warning version).
The full build string is stored (e.g.
BRADLEY ECHO (5.1.4)). as well as the individual MAJOR/MINOR/PATCH values. If this is overkill, then we can just save the major/minor/patch int values only.To support all character types for translations and fit nicely on the file select screen, I opted to force the dialog message system to be usable-ish on the file select screen.
The dialog system relies on a PlayState being passed around, but that isn't available to us from the file select. In the basic instance of using the dialog system, we only need a Gfx pointer and the MessageContext. To take advantage of the dialog system, I've stubbed out a "dummy" PlayState that I can attach the graphics context and message context to, then I explicitly call Message methods to retrieve and render the rando warning text in a single frame.
I'd like to expand this dialog system to be more robust to support other text displays, but want to at least have something in place for this rando version warning text.
Looking for suggestion on the warning text wording! I can also try to show the build version the save was created on so users know which version to go back to if they want to continue that save.
Closes #2383
I also slightly tweaked the rando hash icons to use the same alpha values as the file info so they fade in and out more elegantly
Build Artifacts