Repository navigation
Commit 012fb52
committed
[fix](be) Preserve padding for complex array_agg states
### What problem does this PR solve?
Issue Number: close apache#65976
Related PR: apache#66601
Problem Summary: Native DataType deserialization may read STREAMVBYTE_PADDING bytes past the logical compressed payload. Copying the framed complex array_agg state into an exact-size std::string discarded the padded ColumnString backing buffer and also imposed the generic 1 GiB string limit. Deserialize directly from the framed padded buffer, validate the logical payload length, and advance the reader by that length.
### Release note
Fix complex array_agg state deserialization for StreamVByte-compressed payloads.
### Check List (For Author)
- Test: Unit Test
- Unit Test: GLIBC_COMPATIBILITY=OFF ./run-be-ut.sh -j 48 --run --filter=AggregateFunctionArrayAggTest.*
- Behavior changed: Yes. StreamVByte-compressed complex array_agg states now retain the required readable padding during deserialization.
- Does this need documentation: No1 parent fb66708 commit 012fb52
2 files changed
Lines changed: 14 additions & 5 deletions
File tree
- be
- src/exprs/aggregate
- test/exprs/aggregate
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
280 | 280 | | |
281 | 281 | | |
282 | 282 | | |
283 | | - | |
284 | | - | |
285 | | - | |
286 | | - | |
287 | | - | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
288 | 289 | | |
289 | 290 | | |
290 | 291 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
275 | 275 | | |
276 | 276 | | |
277 | 277 | | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
278 | 286 | | |
279 | 287 | | |
280 | 288 | | |
| |||
0 commit comments