-
Notifications
You must be signed in to change notification settings - Fork 914
[core] Rework m_bListening to lock-free and m_GlobControlLock to use shared mutex #3189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cl-ment
merged 16 commits into
Haivision:master
from
ethouris:dev-rework-mutex-to-shared
Aug 26, 2025
Merged
[core] Rework m_bListening to lock-free and m_GlobControlLock to use shared mutex #3189
cl-ment
merged 16 commits into
Haivision:master
from
ethouris:dev-rework-mutex-to-shared
Aug 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d571a74 to
aaa467f
Compare
… be created (required exclusive)
cl-ment
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
m_GlobControlLocktoSharedMutex. Most of the uses are still exclusive, except:locateSocketand other lookup functions - these useSharedLockon itcloseAllSocketscalls closing function on all sockets first underSharedLock, then runs the loop again this time onExclusiveLockm_ControlLockinsetListenerState. Instead the exclusive access is ensured throughcompare_exchangecall onm_bListeningatomic field with a fallback in case when the "winner" happened to fail setting up the listener.The ThreadSanitizer reports one situation described as "T1: Shared(A), Shared(B)", "T2: Shared(B), Exclusive(A)". According to the analysis this doesn't form a potential deadlock, although ThreadSanitizer reports it as such.