-
Notifications
You must be signed in to change notification settings - Fork 914
Update cxx11-macos.yaml #3170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cxx11-macos.yaml #3170
Conversation
Downgrade googletest to 1.16.x as latest one requires C++ 17
|
That didn't seem to work. Might be that USER is not defined. |
|
$USER should be defined but this seems to be a git config issue now in the virtual environment, might be better to download the exact brew formula that has the wanted version from homebrew git history as cloning the whole repo as I originally suggested is excessively heavy. I can check this out, but @ethouris do you recall which Gtest version is known to work with this project? Edit: latest commit installs v1.16 |
try to download the exact version of google test formula from homebrew history
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V1.16.0 is the last Gtest that supports C++ 14
"The 1.16.x branch will be the last to support C++14. Future development will require at least C++17."
https://github.com/google/googletest/releases/tag/v1.16.0
|
The exact versions are defined in the cmake file. Find the definition of GTest installation. # Version ranges are only supported with CMake 3.19 or later.
# Need GTest v1.10 or higher to support GTEST_SKIP.
if (${CMAKE_VERSION} VERSION_LESS "3.19.0")
find_package(GTest 1.10)
else()
find_package(GTest 1.10...1.12)
endif() |
downgrade googletest to 1.12.1
yaruno
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
downgrade googletest to 1.12.1
|
LOL I'm afraid that you'll have to merge both changes together - fixed Google test installation in CI and lifting the CMake version. At least we know from CI that Google Test installation has passed and is accepted. The problem is only with version compat on Mac. You might do a premature merge of this PR to #3167 in order to test if it fixed the problem. Then we will merge them in this order. |
Heh, that seems to be the case. I've merged 3167 to this one. Lets see if it compiles happily now. |
|
Unfortunately I'm not able to trigger the workflows, but if @ethouris can trigger it on when you have a moment then we'll see if it's working as intended. |
|
Sure! |
Looks like OSX builds now successfully. |
|
Any timeline when we'll get this merged to main? Would love to have it as soon as possible to fix my build processes (and to continue fixing node-js wrapper for it https://github.com/Eyevinn/node-srt). |
Downgrade googletest to 1.16.x as latest one requires C++ 17