[build] + [core] compilation of SRT on platforms that do not support the pthread_condattr_setclock function. #3152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cl-ment
added
Type: Maintenance
maxsharabayko
approved these changes
Mar 26, 2025
Collaborator
maxsharabayko
left a comment
maxsharabayko
left a comment
There was a problem hiding this comment.
Apart from the formatting comment LGTM. 👍
CMakeLists.txt
Outdated
Comment on lines
965
to
978
| message(STATUS "Pthread library: ${PTHREAD_LIBRARY}") | ||
| endif() | ||
|
|
||
| # To avoid the need for other judgments when ENABLE_STDCXX_SYNC is OFF in the future, this is a separate conditional statement. | ||
| if (NOT ENABLE_STDCXX_SYNC AND ENABLE_MONOTONIC_CLOCK) | ||
| list(PREPEND CMAKE_REQUIRED_LIBRARIES "${PTHREAD_LIBRARY}") | ||
| check_symbol_exists(pthread_condattr_setclock "pthread.h" HAVE_PTHREAD_CONDATTR_SETCLOCK) | ||
| if (HAVE_PTHREAD_CONDATTR_SETCLOCK) | ||
| add_definitions(-DHAVE_PTHREAD_CONDATTR_SETCLOCK=1) | ||
| else () | ||
| message(WARNING, "Can't find pthread_condattr_setclock. Try -DENABLE_STDCXX_SYNC=ON or -DENABLE_MONOTONIC_CLOCK=OFF; the latter is not recommended though.") | ||
| endif () | ||
| endif () | ||
|
|
Collaborator
There was a problem hiding this comment.
Indent using tabs, please.
Collaborator
There was a problem hiding this comment.
Maybe add_definitions(-DHAVE_PTHREAD_CONDATTR_SETCLOCK=0) otherwise? Not necessary though. Just a thought.
Collaborator
There was a problem hiding this comment.
Not necessary. If this function doesn't exist, monotonic clock should be simply off, as it's not usable, and SRT with this enforced won't be simply usable at all.
Collaborator
|
Travis PowerPC jobs seems to be failing on the google tests's cmake configure stage. 🤔 |
Collaborator
|
This is idiotic. No indication of an error at all. Maybe add to .travis.yml some thing like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes an alternative to PR #3138 and #3149, both of which address the compilation of SRT on platforms that do not support the
pthread_condattr_setclockfunction. To achieve this, we introduced a new compilation flag,HAVE_PTHREAD_CONDATTR_SETCLOCK, which is separate fromENABLE_MONOTONIC_CLOCK. Additionally, we moved the function availability check to occur after determining the thread library.