Skip to content

Conversation

@ethouris
Copy link
Collaborator

Fixes #3137.

Changes:

  1. Unlock the mutex of m_RcvBufLock, which should guard the ACK sequence recorded by another thread. The lock is not necessary at the moment when the prepared packet is about to be sent.
  2. As the nonblocking mode was set using either O_NONBLOCK flag (by fcntl) or short timeout on the socket, depending on the system, for consistency the non-blocking mode should be set in both directions. Therefore added setting also SO_SNDTIMEO flag with the same value.

@ethouris ethouris added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Mar 12, 2025
@ethouris ethouris added this to the v1.5.5 milestone Mar 12, 2025
@cl-ment cl-ment merged commit 4d0e984 into Haivision:master Mar 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ::sendmsg may block all threads in a weak network

3 participants