[core] Fixed THREAD_STATE_INIT usage in CRcvQueue. #3001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Bug
ethouris
approved these changes
Aug 8, 2024
jeandube
reviewed
Aug 8, 2024
Collaborator
jeandube
left a comment
jeandube
left a comment
There was a problem hiding this comment.
Is the distinction between LOGGING/!not LOGGING required, since it is handled in ::init already?
Shouldn't the same fix be applied to the SndQ as well?
Collaborator
Author
You are right. Fixed in the second commit. |
jeandube
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CRcvQueue::m_countervariable is shared between threads. TheTHREAD_STATE_INITmacro used the value to form the thread name, but the value could be the same for several threads.The thread must already have a name set via
ThreadName. Therefore just extract it viaThreadName::get(std::string&).Fixes #2973.