[MAINT] Removed reference fields from CPacket pinned to the SRT header #2594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 23, 2022 12:50
1 task
maxsharabayko
added
Type: Maintenance
ethouris
pushed a commit
to ethouris/srt
that referenced
this pull request
May 8, 2023
6 tasks
ethouris
pushed a commit
that referenced
this pull request
May 8, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2594 +/- ##
==========================================
- Coverage 66.99% 66.79% -0.20%
==========================================
Files 103 103
Lines 20460 20470 +10
==========================================
- Hits 13707 13673 -34
- Misses 6753 6797 +44 ☔ View full report in Codecov by Sentry. |
Collaborator
maxsharabayko
left a comment
maxsharabayko
left a comment
There was a problem hiding this comment.
Consider minor comments.
I am a bit concerned the naming convention is not followed, i.e. set_timestamp instead of setTimestamp function names are used. I guess that might be tricky to do set with upper case, but get without the get itself, only using the work starting with lowercase.
Co-authored-by: Maxim Sharabayko <[email protected]>
maxsharabayko
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference fields like
m_iSeqNothat were set to the value in the objects self parts of the array keeping the header have been turned into methods.Only
m_pcDatais left unchanged because this is much more complicated.