Skip to content

Fixed: connected peer address not recorded #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxsharabayko merged 1 commit into from
Nov 9, 2022
Merged

Fixed: connected peer address not recorded #2526

maxsharabayko merged 1 commit into from
Nov 9, 2022

Conversation

@ethouris
Copy link
Collaborator

@ethouris ethouris commented Nov 9, 2022

Fixes #2485

@ethouris ethouris added Priority: High Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core [tests] Area: Unit tests labels Nov 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #2526 (7b9c0b6) into master (b76c8b2) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2526      +/-   ##
==========================================
+ Coverage   66.00%   66.12%   +0.12%     
==========================================
  Files          99      100       +1     
  Lines       19750    19778      +28     
==========================================
+ Hits        13036    13079      +43     
+ Misses       6714     6699      -15
Impacted Files Coverage Δ
srtcore/api.cpp 54.63% <100.00%> (+0.07%) ⬆️
test/test_socketdata.cpp 100.00% <100.00%> (ø)
srtcore/cache.h 80.00% <0.00%> (-3.08%) ⬇️
srtcore/congctl.cpp 80.31% <0.00%> (-2.60%) ⬇️
srtcore/netinet_any.h 88.77% <0.00%> (-1.03%) ⬇️
srtcore/queue.cpp 81.04% <0.00%> (-0.60%) ⬇️
srtcore/core.cpp 60.11% <0.00%> (+0.19%) ⬆️
srtcore/buffer_rcv.cpp 59.02% <0.00%> (+0.19%) ⬆️
test/test_bonding.cpp 98.42% <0.00%> (+0.52%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maxsharabayko maxsharabayko added this to the v1.6.0 milestone Nov 9, 2022
@maxsharabayko maxsharabayko merged commit f477b51 into Haivision:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxsharabayko maxsharabayko Awaiting requested review from maxsharabayko

Assignees

No one assigned

Labels

[core] Area: Changes in SRT library core Priority: High [tests] Area: Unit tests Type: Bug Indicates an unexpected problem or unintended behavior

Projects

None yet

Milestone

v1.5.2

Development

Successfully merging this pull request may close these issues.

Peer address not available through srt_getpeername() upon epoll TX_READY event

3 participants

@ethouris @codecov-commenter @maxsharabayko