[core] Fixed guard for rcv-rexmit fields #1859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
ethouris
added
[core]
added 2 commits
June 1, 2021 09:51
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Aug 17, 2021
Imported from Haivision#1859. Co-authored-by: Mikolaj Malecki <[email protected]>
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Aug 17, 2021
Imported from Haivision#1859. Co-authored-by: Mikolaj Malecki <[email protected]>
maxsharabayko
added a commit
that referenced
this pull request
Aug 17, 2021
Imported from #1859. Co-authored-by: Mikolaj Malecki <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1859 +/- ##
==========================================
+ Coverage 64.57% 64.61% +0.03%
==========================================
Files 91 91
Lines 19307 19317 +10
==========================================
+ Hits 12467 12481 +14
+ Misses 6840 6836 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The following fields should be declared as guarded by m_RecvAckLock:
They are already guarded in other places; this fix makes the guard consistent, including in places where these data are being read.
Tested with a trial transmission with the use of broadcast group. No deadlocks found and the lock ordering rule described in LowLevelInfo is preserved.